!4257odin/memoless-internal → develop3e17f25c36

Memoless internal transactions skip handler processing

AI-generatedEverything on this page was written by an AI agent from the diff: the summaries, the narration, the diagrams, the flags and the glossary. It can be wrong or incomplete, so check it against the code before you rely on it.

9commits
30files
5.6klines changed
232lines to read
addr_pk/new KV prefix
noneversion gate

Where the diff is

Blank-memo vault transfer through the quorum handler

Churn fills an address map; the quorum handler uses it to skip handlers

newchanged

3-minute explainer

What changed

The problem

Blank-memo vault transfers were treated like user deposits

vault Ablank memovault B

Address map

addr_pk/ keeps vault address → pubkey, O(1) lookup

SetGetHasDeleteIterator

Filled at churn

Genesis and RotateVault write mappings; nothing removes them

genesis vaultsretiring vaultsnew active vault

Skip the handler

Internal blank-memo tx: no reference memo, return before handler

creditinactive? refundreturn

Internal memos kept

Migrate/consolidate outbounds always keep their memo

MIGRATE memokeptskip = defensive

Address query

GET /thorchain/vaults/address/{address} → pubkey, found

State + upgrade

Store and proto added

KV prefix addr_pk/
+ address → pubkey string
QueryAddrPubKeyRequest
+ address+ height
QueryAddrPubKeyResponse
+ pubkey+ found

Line by line · every changed logic line, narrated

4:44runtime
6code chapters
100%logic lines narrated (163/163)
8flagged spots
speed

Chapters

What to check

Ask an AI about this change

Chat assistantClaude, ChatGPT, … (reads a link)

Coding agentClaude Code, Cursor, … (reads the repo)

The context file is context.md. Use Copy with context for an AI that can't open links; it pastes the whole file in.

Glossary

AlgoPubKey
Returns the vault pubkey for a chain's signing algorithm (secp256k1 or EdDSA).
Churn
Periodic validator-set rotation; RotateVault retires old Asgard vaults and activates the new one. manager_network_current.go ↗
Divergence prefix map
Registry of keeper KV prefixes used to diagnose app-hash divergence; every new prefix must be listed. prefixes.go ↗
Internal transaction
A vault-to-vault transfer (migrate or consolidate); here, any tx whose sender and recipient both have an addr_pk/ mapping. memo.go ↗
Memoless
Transactions sent without a memo; THORChain matches inbounds by a reference memo and can strip outbound memos. helpers.go ↗
Migrate / consolidate
Migrate moves funds from a retiring vault to the new one at churn; consolidate merges UTXOs within a vault.
Reference memo
A short r:<id> memo synthesized for blank-memo inbounds so they can be matched to a registered memo.